Ethereal-dev: Re: [Ethereal-dev] lot's of warnings: redefinition of symbol 'OPTIONAL'

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 9 Oct 2003 12:01:12 -0700

On Oct 8, 2003, at 8:08 AM, Ulf Lamping wrote:
As the name OPTIONAL isn't very unique, I would suggest to rename OPTIONAL in file packet-per.h to something like PER_OPTIONAL or such and change the .c files using this define.
That sounds reasonable. Is that form of "optional" PER-specific, or generic to ASN.1? If the latter, perhaps ASN1_OPTIONAL would be better. (At some point we might want to look at dissecting ASN.1 BER in a fashion similar to the way we dissect PER.)
Of course, it would be also a good idea to rename the other similiar defines in the file packet-per.h to something more unique... :-) 

Yes.  The same PER-vs-ASN.1 question applies to them as well.