Hi !
KTi> -----Original Message-----
KTi> From: ext Guy Harris [mailto:guy@xxxxxxxxxxxx]
KTi> Sent: 08 September, 2003 23:46
KTi> To: Tiirikainen Kari (NET-OSS/Espoo)
KTi> Cc: ethereal-dev@xxxxxxxxxxxx
KTi> Subject: Re: [Ethereal-dev] Updates to COPS & SNMP dissectors
KTi>
KTi> That patch didn't apply correctly, as it wasn't a "-c" or
KTi> "-u" patch, but, fortunately, it wasn't *too* wrong, so I could fix
KTi> the damage by hand.
Thank you, although there wasn't such a rush,
so by now you should have gotten the correct diff.
KTi> However, I changed it so that there's a routine
KTi> "process_prefs()" which
KTi> is called when the preferences change; it unloads the MIBs
KTi> if they've
KTi> been loaded (false the first time through, true all
KTi> subsequent times through), exports the preference setting,
KTi> and then loads the MIBs.
OK, sounds fine to me.
KTi> Note that there is no such thing as a preference that
KTi> hasn't been set,
KTi> i.e., by the time the preferences are read, it is
KTi> *guaranteed* to be
KTi> the case that "mib_modules" is set - and that'd be the
KTi> case even if the
KTi> register routine *didn't* give it an initial value.
OK, good to know. I checked packet-diameter.c for reference
when coding the preference setting and there was the checking too,
so I used it too.
KTi> That's what's currently checked in.
Looks great, thanks.
Regards,
Kari
