Ethereal-dev: Re: [Ethereal-dev] Cleanup - conversation includes

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 3 Sep 2003 14:00:49 -0700

On Tuesday, July 8, 2003, at 4:37 AM, Biot Olivier wrote:


After inspection the following dissector sources include
<epan/conversation.h> but don't use it:


	...


packet-ncp2222.c (generated with ncp2222.py)


It includes "packet-ncp2222.inc", which *does* use conversations.


packet-scsi.c
It needs to include <epan/packet.h>, which <epan/conversation.h> happens to include, so the include has to be replaced by an include of <epan/packet.h>. 


I propose to have these extraneous includes removed.


I've checked in the changes that apply.