Ethereal-dev: Re: [Ethereal-dev] Updated find capabilities.

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Greg Morris" <GMORRIS@xxxxxxxxxx>
Date: Thu, 14 Aug 2003 16:39:18 -0600
Yes,
 
I need to spend some time and consolidate the find_gtk and find_ascii functions.
 
Greg

>>> Richard Sharpe <rsharpe@xxxxxxxxxxxxxxxxx> 8/14/2003 4:42:08 PM >>>
On Thu, 14 Aug 2003, Greg Morris wrote:

> Sorry for the confusion, I hadn't performed a CVS update since the last
> checkin so I didn't see the changes. The attached diff will patch file.c
> to include the check for buffer overrun.

Applied, after removing the merge conflict marker that looked wrong. I
made sure that this builds, but have not tested the change otherwise.

My only other comment is that we now seem to have two duplicate pieces of
code that should be a subroutine for ease of maintenance ...

Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org,
sharpe[at]ethereal.com, http://www.richardsharpe.com