Ethereal-dev: Re: [Ethereal-dev] RTNET/TDMA plugin in

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Tue, 15 Jul 2003 22:05:45 -0700
On Thu, Jun 12, 2003 at 12:34:32AM +0200, Erwin Rol wrote:
> On Wed, 2003-06-11 at 11:19, Guy Harris wrote:
> > On Mon, Jun 09, 2003 at 11:55:02AM +0200, Erwin Rol wrote:
> > Here are some warnings GCC produced:
> > 
> > 	packet-rtnet.c: In function `dissect_rtnet_tdma_notify_master':
> > 	packet-rtnet.c:160: warning: unused parameter `tvb'
> > 	packet-rtnet.c:160: warning: unused parameter `tree'
> > 
> > Is that a routine that needs to be written, or is that an empty message
> > type (in which case the arguments in question should have _U_ after
> > them)?
> 
> I wasn't sure if there was data for this message so i added the empty
> function as a place holder. I will add the _U_ (or you could do that
> since i will have to send you the patch anyway).

From a quick look at the code ("tdma_task_notify()" in
"rtmac/tdma_task.c") in the lxr site:

	http://www.rts.uni-hannover.de/rtnet/lxr/source/rtmac/tdma_task.c

it appears that NOTIFY_MASTER doesn't have any data.  Tim Potter checked
in changes to add _U_ to those arguments.

Attachment: pgpJhsdl79Yp7.pgp
Description: PGP signature