Ethereal-dev: Re: [Ethereal-dev] Changing dissect_rpc_data which is called from dissect_nfsdat

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <rsharpe@xxxxxxxxxxxxxxxxx>
Date: Tue, 20 May 2003 09:41:37 -0700 (PDT)
On Tue, 20 May 2003, Guy Harris wrote:

> 	3) have "dissect_rpc_opaque_data()" take an extra argument,
> 	   modify the few calls there are to *it*, export it from
> 	   "packet-rpc.c", have "dissect_nfs_rpcsec_gss_info()" call
> 	   "dissect_rpc_opaque_data()", and don't change
> 	   "dissect_nfsdata()" (except perhaps to eliminate it in favor
> 	   of calling "dissect_rpc_data()" directly!) or
> 	   "dissect_rpc_data()" at all.

OK, following up on this, dissect_rpc_opaque_data does a lot of work to 
extract the data to be dissected. However, it seems to me that I should 
simply create a new TVB and then call the passed dissector with the new 
TVB. 

The issue that concerns me is bounds checking. Will the process of 
creating the new TVB throw the appriopriate exceptions when there is 
insufficient data there?

Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, 
sharpe[at]ethereal.com, http://www.richardsharpe.com