Ethereal-dev: [Ethereal-dev] patch to add id'ing of new types from netbios name services

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Jim McDonough <jmcd@xxxxxxxxxx>
Date: Thu, 1 May 2003 08:32:35 -0400


The following patch properly ID's types x17 and x19 in the mailslot
protocol for netbios name services.  It doesn't decode them, just ID's
them.

Index: packet-smb-logon.c
===================================================================
RCS file: /cvsroot/ethereal/packet-smb-logon.c,v
retrieving revision 1.31
diff -u -r1.31 packet-smb-logon.c
--- packet-smb-logon.c  3 Apr 2003 02:57:48 -0000     1.31
+++ packet-smb-logon.c  1 May 2003 12:22:40 -0000
@@ -750,7 +750,10 @@
 #define LOGON_SAM_RESPONSE_DURING_LOGON        0x14
 #define LOGON_SAM_USER_UNKNOWN                 0x15
 #define LOGON_SAM_INTERROGATE_RESPONSE         0x16
-#define LOGON_LAST_CMD                   0x17
+#define LOGON_SAM_AD_USER_UNKNOWN        0x17
+#define LOGON_SAM_UNKNOWN_18             0x18
+#define LOGON_SAM_AD_LOGON_RESPONSE            0x19
+#define LOGON_LAST_CMD                   0x20

 static const value_string commands[] = {
      {LOGON_LM10_LOGON_REQUEST,    "LM1.0/LM2.0 LOGON Request"},
@@ -776,6 +779,9 @@
      {LOGON_SAM_RESPONSE_DURING_LOGON,"SAM Response during LOGON pause"},
      {LOGON_SAM_USER_UNKNOWN,      "SAM Response - user unknown"},
      {LOGON_SAM_INTERROGATE_RESPONSE,"SAM Response to Interrogate
Request"},
+     {LOGON_SAM_AD_USER_UNKNOWN,   "SAM Active Directory Response - user
unknown"},
+     {LOGON_SAM_UNKNOWN_18,        "SAM unknown command 0x18"},
+     {LOGON_SAM_AD_LOGON_RESPONSE, "Active Directory Response to SAM LOGON request"},
      {0,   NULL}
 };

@@ -804,6 +810,9 @@
      dissect_smb_unknown,        /* 0x14 (SAM Response during LOGON Pause) */
      dissect_smb_unknown,        /* 0x15 (SAM Response User Unknown)      */
      dissect_smb_unknown,        /* 0x16 (SAM Response to Interrogate)   */
+     dissect_smb_unknown,        /* 0x17 (SAM AD response User Unknown */
+     dissect_smb_unknown,        /* 0x18 (Unknown command)           */
+     dissect_smb_unknown         /* 0x19 (SAM LOGON AD response)     */
 };



----------------------------
Jim McDonough
IBM Linux Technology Center
Samba Team
6 Minuteman Drive
Scarborough, ME 04074
USA

jmcd@xxxxxxxxxx
jmcd@xxxxxxxxx

Phone: (207) 885-5565
IBM tie-line: 776-9984