Ethereal-dev: Re: [Ethereal-dev] Re: TCP retransmission in BGP dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Tue, 15 Apr 2003 02:59:37 -0700
On Tue, Apr 15, 2003 at 07:33:03PM +1000, Ronnie Sahlberg wrote:
> What I think would be a reasonably clean way to solve this would be to
> 1,   rename pinfo->desegment_len  which is currently only used by dissectors
> to tell how many more bytes
> it needs to be reassembled to get the full PDU   to
> pinfo->bytes_until_next_pdu_starts.
> Extend this value to both act as reporting how much more data we need for
> reassembly and also as information to where the next PDU starts.  (trivial)

Note that the dissector won't be able to indicate how many bytes there
are until the next PDU starts if the PDU header that has a length is
split across segment boundaries and you're looking at the first segment,
because you'll have to do desegmentation just to find out how big the
packet is.

I.e., in that case, it can report how much data is needed for
reassembly, but it can't report where the next PDU starts, as it needs
the specified amount of data in order to find the length of the PDU an
thus to find where the next PDU starts.