Ethereal-dev: [Ethereal-dev] Win32 file version

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Graham Bloice" <graham.bloice@xxxxxxxxxxxxx>
Date: Wed, 26 Mar 2003 16:40:06 -0000
The RC_VERSION variable in config.nmake should be comma separated.  This
allows the resources to be built correctly and the version number to be
correctly displayed in the explorer properties dialog for the executables,
and XP's tooltip, rather than 0.0.0.0.  The attached patch also adds a
dependency on config.nmake to the resources to ensure they get built.

Regards,

Graham
Index: config.nmake
===================================================================
RCS file: /cvsroot/ethereal/config.nmake,v
retrieving revision 1.36
diff -u -r1.36 config.nmake
--- config.nmake  11 Mar 2003 00:12:35 -0000  1.36
+++ config.nmake  26 Mar 2003 16:34:10 -0000
@@ -1,7 +1,7 @@
 # $Id: config.nmake,v 1.36 2003/03/11 00:12:35 gerald Exp $
 
 VERSION=0.9.11
-RC_VERSION=0.9.11
+RC_VERSION=0,9,11
 WTAP_VERSION=0.0
 
 GTK_VERSION=1.3
Index: image/Makefile.nmake
===================================================================
RCS file: /cvsroot/ethereal/image/Makefile.nmake,v
retrieving revision 1.4
diff -u -r1.4 Makefile.nmake
--- image/Makefile.nmake  12 Jul 2001 21:02:06 -0000  1.4
+++ image/Makefile.nmake  26 Mar 2003 16:34:10 -0000
@@ -7,27 +7,27 @@
 ALL_RC=ethereal.rc tethereal.rc editcap.rc text2pcap.rc mergecap.rc
 all : $(ALL_RC)
 
-ethereal.rc  : ethereal.rc.in
+ethereal.rc  : ethereal.rc.in ..\config.nmake
  sed -e s/@VERSION@/$(VERSION)/ \
    -e s/@RC_VERSION@/$(RC_VERSION)/ \
    < ethereal.rc.in > $@
 
-tethereal.rc : tethereal.rc.in
+tethereal.rc : tethereal.rc.in ..\config.nmake
  sed -e s/@VERSION@/$(VERSION)/ \
    -e s/@RC_VERSION@/$(RC_VERSION)/ \
    < tethereal.rc.in > $@
 
-editcap.rc : editcap.rc.in
+editcap.rc : editcap.rc.in ..\config.nmake
  sed -e s/@VERSION@/$(VERSION)/ \
    -e s/@RC_VERSION@/$(RC_VERSION)/ \
    < editcap.rc.in > $@
 
-mergecap.rc  : mergecap.rc.in
+mergecap.rc  : mergecap.rc.in ..\config.nmake
  sed -e s/@VERSION@/$(VERSION)/ \
    -e s/@RC_VERSION@/$(RC_VERSION)/ \
    < mergecap.rc.in > $@
 
-text2pcap.rc : text2pcap.rc.in
+text2pcap.rc : text2pcap.rc.in ..\config.nmake
  sed -e s/@VERSION@/$(VERSION)/ \
    -e s/@RC_VERSION@/$(RC_VERSION)/ \
    < text2pcap.rc.in > $@