Ethereal-dev: Re: [Ethereal-dev] PPP dissector bug

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Mon, 10 Mar 2003 19:05:32 -0800
On Mon, Mar 10, 2003 at 07:56:19PM -0700, Irfan Khan wrote:
> Yup, these are framing bytes.  I thought it better to put the check for 
> any unexpected 0x7e s in packet-ppp to make it more bug-proof :)

But what if there happens to be a PPP protocol with a value 0x7eXX, for
some value of "XX"?  Unlikely, I suspect, but should we be stripping
0x7e's out unconditionally?

(And what were the 0x7e's doing in there?  Incorrect stripping of link
framing by the LAC?)