Ethereal-dev: [Ethereal-dev] Patch: AIM dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: dheitmueller <dheitmueller@xxxxxxxxxxx>
Date: Sat, 11 Jan 2003 17:36:53 -0500 (EST)
Attached is a patch that restructures the AIM dissector.  The changes are mainly as follows:

* Break up dissection into separate functions
* Added families not already present (based on GAIM source code)
* Added entries from the "generic" family not already present
* Started to break families and subtypes into constants instead of
  having hardcoded values (signon and generic are done, others in
  progress)

As far as I know, I have not made anything worse, although I have found several issues that were already present (that are still unfixed).  

I know this patch represents a whole lot of code changed, with little visible improvement to dissection.  This patch is mostly just about getting the infrastruture necessary to start fleshing out the individual messages.

Comments welcome as always,

Devin Heitmueller
Senior Software Engineer
Netilla Networks Inc

Attachment: packet-aim.c.diff2.gz
Description: application/gzip