I am working on cleaning my code in
packet-dcerpc-afs4int.c.
So farI have made a macros header file to house all
the common dissection structures.
This will allow me to complete all the dissectors for
afs4int, and keep it very clean.
Now I am stuck at weather to choose the method of
using a generic var for hf, e.g.
hf_afs4int_gen_uint32, or to choose the
proto_tree_add_xxx functions, which will give more
descriptive names. Was not sure the direction I should
go. Any help is greatly appreciated!
I want this to be clean enough, that it can be
commited with minimal effort.
Thanks!
--- Pia Sahlberg <piabar@xxxxxxxxxxx> wrote:
> The AFS dissector is very old and close to
> unmaintained.
> It is "ugly" and contains a lot of bugs, especially
> for short packets.
>
> Feel free to implement your afs dissector completely
> differently from
> the way packet-afs.c is implemented.
>
>
>
>
>
>
>
> >From: Jaime Fournier <jafour1@xxxxxxxxx>
> >Reply-To: jafour1@xxxxxxxxx
> >To: Pia Sahlberg <piabar@xxxxxxxxxxx>
> >Subject: Re: [Ethereal-dev] Patch for rpcstat for
> DCERPC services.
> >Date: Thu, 24 Oct 2002 21:29:20 -0700 (PDT)
> >
> >Saw it.
> >So you found something new in the epm packets I
> sent
> >you?
> >Cool.
> >Will check out the patch tonight.
> >This weekend I am going to work to massively redo
> the
> >afs4int
> >dissectors. As it represents ALL the calls in DFS.
> >Now that I understand the reuse of hf_ varibables,
> I
> >will cut down the total number of var definitions.
> >Not sure if you want common structure definitions
> to
> >be
> >macros like they are in afs stuff.
> >Let me know if you have any preference.
> >
> >Thanks!
> >--- Pia Sahlberg <piabar@xxxxxxxxxxx> wrote:
> > > Hi,
> > >
> > > A patch to fix the bug you saw with weird RTT
> > > statistics has been checked
> > > in.
> > >
> > >
> > >
> > >
>
>_________________________________________________________________
> > > Broadband? Dial-up? Get reliable MSN Internet
> > > Access.
> > >
>
>http://resourcecenter.msn.com/access/plans/default.asp
> > >
> >
> >
> >=====
> >Jaime Fournier
> >
> >__________________________________________________
> >Do you Yahoo!?
> >Y! Web Hosting - Let the expert host your web site
> >http://webhosting.yahoo.com/
>
>
>
_________________________________________________________________
> Surf the Web without missing calls! Get MSN
> Broadband.
>
http://resourcecenter.msn.com/access/plans/freeactivation.asp
>
=====
Jaime Fournier
__________________________________________________
Do you Yahoo!?
Y! Web Hosting - Let the expert host your web site
http://webhosting.yahoo.com/
