Ethereal-dev: [Ethereal-dev] Thanks for the help cleaning up the NCP code.

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Greg Morris" <GMORRIS@xxxxxxxxxx>
Date: Fri, 18 Oct 2002 10:19:00 -0600
Guy,
 
I really appreciate all the work you have put into this. I hope that you have not been pulling out too much hair over it.
 
You mentioned the get_string function, I have been testing with modifying nw_uni to set the maximum size for a string to 1024. I have not found any string that exceeded that length.
 
Also the changes for allowing SPX to pass to subdissectors is great, but, Should'nt it first evaluate if there is any additional payload to pass? I have made a quick change so that it evalutates to see if it has a payload of at least 4 bytes prior to passing to a sub-dissector.
 
What do you think?
Greg
 
 

Attachment: packet-ncp2222.inc.diff
Description: Binary data

Attachment: packet-ipx.c.diff
Description: Binary data