On Mon, Sep 23, 2002 at 07:17:36PM +0200, Joerg Mayer wrote:
> On Mon, Sep 23, 2002 at 10:43:36AM -0600, Greg Morris wrote:
> > Attached is an attempt to dissect Novell Distributed Print Services.
> > NDPS runs on top of SPX and TCP.
>
> Checked in. Please note that I got a few warnings while compiling your
> new code:
>
> ============================================
> packet-ncp.c:93: warning: type defaults to `int' in declaration of `ncp_nds_true'
> packet-ncp.c:85: warning: `hf_ping_version' defined but not used
> packet-ncp.c:93: warning: `ncp_nds_true' defined but not used
> packet-ndps.c: In function `dissect_ndps_common':
> packet-ndps.c:730: warning: empty body in an if-statement
This is probably a bogus semicolon -
if(ndps_hfname != 0);
should probably be
if(ndps_hfname != 0)
I'll check that fix in.
> packet-ndps.c:582: warning: `conn_ctrl' might be used uninitialized in this function
> packet-ndps.c: In function `proto_reg_handoff_ndps':
> packet-ndps.c:894: warning: unused variable `spx_handle'
Those are a bit odd. It looks as if the NDPS dissector is dissecting
the SPX header; however, it's called from the SPX dissector, and that
dissector hands subdissectors a tvbuff that doesn't include the SPX
header.
The correct fix is probably to get rid of the stuff to dissect the SPX
header (which gets rid of the "conn_ctrl" warning), get rid of the
"hf_spx[]" array and calls to use it, get rid of "proto_spx" and the
call to set it, get rid of "spx_handle", and get rid of the
commented-out calls that use it.
