-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed, 2 Oct 2002 19:15, Ronnie Sahlberg wrote:
> Checked in.
> The patch did not apply cleanly so i ended up applying it manually.
> No worries.
>
> I assume you did not yet add the conversation stuff to register the
> protocol based on traffic seen discussed earlier on the list?
>
> Two cosmetic suggestions:
> There are a few places where a bitmask is dissected using
> proto_tree_add_text() in the tree. These places should be changed to use
> proto_tree_add_boolean().
That is left over SLPv1 stuff (aka "it wasn't me!"). I used
proto_tree_add_boolean() for the flags in SLPv2.
> In the definition for the hf_index array, the last string element "" before
> the HFILL
> parameter is a description blurb, i.e. what text is displayed to explain
> the field
> in the bottom right textbox when the field is selected.
> A good dissector becomes even better if this text is filled in.
> If you think it is worth it and want to, please consider adding some
> description text to these fields.
It seems to use the label if this is not filled in. I only filled the ones
where I didn't want to just use the label. Didn't seem to be much point in
having duplicate text....
> (as for all other aussies on the list, two weeks from now im having a big
> house warming party
> up towards central coast. if you are in the region you are invited to come
> by and help me drink all the beer.)
Canberra is a bit far...
Brad
- --
http://conf.linux.org.au. 22-25Jan2003. Perth, Aust. Tickets booked.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE9msveW6pHgIdAuOMRAmTlAJ0Qnf5Zkw2ye9z/AhKLZJww5AUu6QCcDH9E
wg2l5t/TssSsTVz8kvkQiLs=
=uymh
-----END PGP SIGNATURE-----
