Ethereal-dev: Re: [Ethereal-dev] Cisco NetFlow (and Juniper Cflowd) dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Ronnie Sahlberg" <sahlberg@xxxxxxxxxxxxxxxx>
Date: Thu, 5 Sep 2002 07:51:03 +1000
From: "Matthew Smart"
Subject: [Ethereal-dev] Cisco NetFlow (and Juniper Cflowd) dissector


> This dissector properly reads NetFlow version 5 and can be
> enhanced to handle version 1, 7, 8, and with a bit more work
> version 9.  I have a lot of code that processes the different
> versions, and I'd be happy to continue to make this dissector
> better if it makes it into the tree.

Looks good,

but you use a lot of proto_tree_add_text().
If you change these to proto_tree_add_item() with proper mathing hf_index
fields
the dissector will be even better since that allows displayfilters to work.