Ethereal-dev: Re: [Ethereal-dev] packet-cpha.c one liner fix (crash)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Wed, 28 Aug 2002 13:04:09 -0700
On Wed, Aug 28, 2002 at 11:59:04AM +0200, Yaniv Kaul wrote:
> Smallest typo (hdr.is_if_trusted instead of hf_is_if_trusted in line 415):

Checked in.

> --- packet-cpha.c       Wed Aug 28 11:54:00 2002
> +++ packet-cpha.fix.c   Wed Aug 28 11:52:53 2002
> @@ -412,7 +412,7 @@
>    proto_tree_add_ether(tree, hf_ethernet_add, tvb, offset, 6,
> hdr.ethernet_add);
>    offset += 6;
> 
> -  proto_tree_add_boolean(tree, hdr.is_if_trusted, tvb, offset,
> sizeof(hdr.is_if_trusted), hdr.is_if_trusted);
> +  proto_tree_add_boolean(tree, hf_is_if_trusted, tvb, offset,
> sizeof(hdr.is_if_trusted), hdr.is_if_trusted);

Your mailer line-wrapped the patch, and I had to undo that to apply the
patch; patches appear to be more likely to be left unmolested by mailers
if sent as attachments.