Ethereal-dev: Re: [Ethereal-dev] packet-isakmp.c modifications

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 18 Aug 2002 12:41:17 -0700
On Sun, Aug 18, 2002 at 12:04:58PM +0200, Yaniv Kaul wrote:
> 1. Proper extraction of data from packet (removed bad tvb_get_ptr() and
> casting the resulting pointer to a structure method).
> 2. Printout of Initator and Responder cookies (per request from VPNC
> organization).

Checked in.

> There was not point diff'ing as the first change is quite big.

Well, one reason for sending changes as patches is compression; however,
another reason is robustness in the face of *other* changes being
applied to the file being changed, e.g. if some other change had been
checked in after you'd done the diff, so even with big changes sending
them out as patches can be a good idea.