Ethereal-dev: Re: [Ethereal-dev] ntlmssp auth3 dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: dheitmueller <dheitmueller@xxxxxxxxxxx>
Date: Sat, 10 Aug 2002 17:23:01 -0400 (EDT)
Quoting Guy Harris <gharris@xxxxxxxxx>:
> We don't have a general universal Ethereal-wide approach for handling
> Unicode strings, but we don't need one in order to eliminate the
> duplicate code - we just need to make the "packet-smb.c" version of
> "get_unicode_or_ascii_string()" take a "Unicode or not" flag rather than
> a "packet_info *" as an argument, change its callers appropriately, and
> make it not static.  That's what I've done (and I moved it to
> "packet-smb-common.c").
> 

My original code did just that.  I was hesitant to commit it this way though as I was concerned about hacking up packet-smb (which I don't own), by replacing the pinfo argument.

Thanks for you help,

Devin Heitmueller
Senior Software Engineer
Netilla Networks Inc