Ethereal-dev: Re: [Ethereal-dev] Patch: Revised NTLMSSP support

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Devin Heitmueller <dheitmueller@xxxxxxxxxxx>
Date: 09 Jul 2002 18:06:47 -0400
Tim,

I originally had the flags with the lower bits displayed first.  Ronnie
Sahlberg suggested that I reverse the order.  I'm indifferent on the
matter, other than that it would be nice if all the modules worked the
same way.

It sounds like there is some disagreement regarding the order.  Whatever
the groups decides is the standard convention, I will commit changes to
follow it.

-Devin

On Tue, 2002-07-09 at 16:50, Tim Potter wrote:
> On Wed, Jul 10, 2002 at 12:32:51AM +1000, Tim Potter wrote:
> 
> > > Please accept this revised patch in place of the one submitted last
> > > night.  This corrects the issues pointed out by Joerg Mayer [unnecessary
> > > include, strip DOS linefeeds, incorrect labels in header].
> > > 
> > > Also attached is the reference trace used to create the dissector.
> > 
> > OK - I'll look at applying this if no-one else objects.
> 
> Since no-one objected I've applied the patches.  I reversed the order of
> the ntlmssp flags bitfield as it seems to be the convention that the
> lower bits are displayed first.  I also added a couple of constants.
> 
> 
> Tim.
-- 
Devin Heitmueller
Senior Software Engineer
Netilla Networks Inc