On Tue, May 21, 2002 at 04:35:24PM -0400, Mike Frisch wrote:
> I have done a spring house cleaning on the code in packet-nfs.c and
> fixed all of the 'TODO's.
Checked in - along with some additional changes to make stuff not used
outside "packet-nfs.c" static.
Some GCC warnings (the line numbers are from the version I checked in):
packet-nfs.c: In function `dissect_nfs_nfsace4':
packet-nfs.c:4526: warning: unused parameter `pinfo'
packet-nfs.c: In function `dissect_nfs_fattr4':
packet-nfs.c:5161: warning: unused parameter `name'
packet-nfs.c: In function `dissect_nfs_secinfo4_res':
packet-nfs.c:6167: warning: unused parameter `pinfo'
packet-nfs.c: In function `dissect_nfs_resop4':
packet-nfs.c:6210: warning: comparison of unsigned expression < 0 is
always false
If the parameter isn't being used, and the function isn't the top-level
dissector for a call or reply, the argument should either be removed (if
it's never going to be used) or used.
In the case of the last of them, "ops" in "dissect_nfs_resop4()" is a
"guint", so it can lever be negative. If NFSv4 says it's signed, "ops"
should be a "gint32", not a "guint"; if NFSv4 says it's unsigned, it
should be a "guint32", the test should be removed, and it should be
printed with "%u" rather than "%d".
