Ethereal-dev: Re: [Ethereal-dev] Assigning -1 to unsigned int

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Sun, 24 Feb 2002 23:58:27 -0800
On Mon, Feb 25, 2002 at 01:37:34AM -0600, Albert Chin wrote:
> packet-icq.c from 0.9.1 has lines like:
>   919: guint16 x1 = -1;
>   964: guint32 uin = -1;
>   1304: unsigned char num = -1;
>   1391: guint16 pktLen = -1;

...none of which are necessary, as there aren't any code paths where the
variables aren't explicitly assigned to with assignment statements but
are used.

I've checked in a change to get rid of the assignments.