Ethereal-dev: Re: [Ethereal-dev] [Bug report] SAMR dissector ?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxxxxxxx>
Date: 24 Feb 2002 15:00:57 -0600
On Sun, 2002-02-24 at 14:59, Jean-Baptiste Marchand wrote:
> Hi,
> 
> I've encountered a problem in current version of ethereal when
> dissecting SAMR messages.
> 
> I've attached the trace that produced the following error message :
> 
> ** ERROR **: file proto.c: line 1116 (proto_tree_add_string): assertion
> failed: (hfinfo->type == FT_STRING)
> 
> When selecting frame 35 (a reply to a ENUM_DOM_ALIASES) in ethereal, the
> program terminates on a failed assertion, with the error message above.

I did some analysis of this, but don't know enough
about the dcerpc-samr dissector to fix it.

dissect_ndr_nt_UNICODE() in packet-dcerpc-samr.c, line 302, is
calling proto_tree_add_string_format() on a field it gets
from a dcerpc_info struct, di->hf_index. In this case,
di->hf_index is pointing to an "Alias" feld, or hf_samr_alias,
which is of type FT_UINT32, not a string.

Thanks for the bug report, and for the capture file that
reproduces the bug. Someone will come along shortly and fix it,
I'm sure.

--gilbert