Ethereal-dev: Re: [Ethereal-dev] packet-snmp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Tue, 19 Feb 2002 01:37:07 -0800
On Tue, Feb 19, 2002 at 05:31:39PM +1100, Andrew Hood wrote:
> Not my choice. I can fall back to Netscape, from which I can only send,
> not receive.
> This any better?

Yup, that one made it through.  (TNEF, bleah.)

However, I think the code

			proto_tree_add_text(tree, tvb, offset, sequence_length,
			    "Enterprise: %s", oid_string);

should use "length" rather than "sequence_length" - that looks like a
cut-and-pasteo.  The stuff to set "unsafe" also shouldn't be necessary -
it's set by the variable bindings code whence the stuff you added was
adopted.

I've checked the change in, with "length" rather than "sequence_length"
in that line, and with the stuff to set "unsafe" removed from that code
(but still in the variable bindings code).