Ethereal-dev: Re: [Ethereal-dev] SAMR bugfixes

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Fri, 8 Feb 2002 03:07:03 -0800
On Fri, Feb 08, 2002 at 09:34:29PM +1100, Ronnie Sahlberg wrote:
> attached is a small patch for samr and ndr pointers.

Checked in.  It looks as if it fixes at least some of the problems I
saw.

You might want to dissect a BUFFER as an FT_BYTES field, if possible,
rather than taking it literally as an array, which results in every
single byte getting an protocol tree entry of its own.

The same applies to a LOGON_HOURS_hours field - although I suspect
that's a 21-byte array just like the array handled by
"add_logon_hours()" in "packet-smb-pipe.c", so we should perhaps
eventually dissect it as the bit array it is; that would require the
units per week value ("Divisions") to figure out how big a time period
each of those bits represents.