Ethereal-dev: Re: [Ethereal-dev] MMSE patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxxxxxxx>
Date: Tue, 8 Jan 2002 12:35:44 -0600
On Tue, 08 Jan 2002 05:38:41 Tom Uijldert wrote:
> Hi all,
> 
> Attached a small patch to packet-mmse.c:
> 
> 	Stops crashing on encountering non-encoded headers.
> 
> Please check in.
> 
> Regards,
> Tom Uijldert          Email: Tom.Uijldert@xxxxxx
> 
> 
+++ packet-mmse.c       Tue Jan  8 11:16:50 2002
@@ -614,7 +614,8 @@
                        proto_tree_add_string_format(mmse_tree,
                                                     hf_mmse_ffheader,
                                                     tvb, offset,
-                                                    length + length2,
NULL,
+                                                    length + length2,
+                                                   
tvb_get_ptr(tvb,offset,1),
                                                     "%s :
%s",strval,strval2);
                        offset += length + length2;
                    }

It stops crashes, but is it correct? Why is the tvb_get_ptr()
passed a length of 1, instead of 'length', or 'length2', or
'length + length2' ?

--gilbert