Wireshark · Ethereal-dev: Re: [Ethereal-dev] Van Jacobson dissector. - tvb_orig() removed

[Irfan Khan <ikhan@xxxxxxxxxxxx>]

Attached is the VJ dissector with the tvb_orig function call removed.  The 
patches
to tvbuff.c and tvbuff.h are consequently no longer needed.  I compiled and 
tested it with
nightly build 12/18.

Cheers!
Irfan

At 12:44 PM 12/19/2001, Guy Harris wrote:
> > IP/TCP and up.  VJ does some pretty horrific layering violations for the
> > sake of performance.  The idea here is (more for tetherial)
>
> Why do Ethereal and Tethereal differ here?
>
> > you end up
> > with what looks like a ppp packet that was never compressed in the
> > uncompressed tab framing info and all, otherwise the uncompressed packet
> > tab contains only IP and up.
>
> So presumably all you need is information from the PPP header; the PPP
> dissector has no clue what information appeared *before* the PPP header,
> and neither does the VJ decompressor.
>
> That information can be supplied using the standard Ethereal mechanism
> for that, wherein the calling dissector sets "pinfo->private_data" to
> point to a local data structure before calling the subdissector.
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev

Attachment: packet-ppp_h.patch
Description: Binary data

Attachment: packet-ppp_c.patch
Description: Binary data

Attachment: packet-vj.c.gz
Description: Binary data