Ethereal-dev: Re: [Ethereal-dev] small idl2eth update

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Bernd Becker <bb@xxxxxxxxxxxxxxx>
Date: Wed, 19 Dec 2001 11:05:06 +0100
On Tue, Dec 18, 2001 at 02:17:38PM +0100, Bernd Becker wrote:

The correct solution to this would probably be to only set the
columns and insert the subtree in the protocol tree after
succesfull dissection.


Unfortunately, a successful dissection involves adding stuff to the
subtree....

Right.



I suspect the answer is, at least for heuristic dissectors, to have the
subdissector create the subtree only if it's decided that it'll return
TRUE.  It should also set the Protocol column only if it's decided that.


I will change the code so that at least the operation-based check is done
before changes to the Proto column and subtree. This will solve the
the problem for the vast majority of IDLs.

Bernd