Ethereal-dev: Re: [Ethereal-dev] can_desegment and smb transaction patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Wed, 28 Nov 2001 23:52:51 -0800
On Wed, Nov 28, 2001 at 12:38:53PM +0000, Pia Sahlberg wrote:
> 2, changes fragment reassembly of transaction smb to only show the 
> defragmented packet for the transaction smb holding the first fragment.
> To see why, test it with a transaction SMB containing a ~60kb PDU or larger.
> The old behaviour had approximately quadratic behaviour regarding
> runtime for dissecting such PDUs.
> (example: NetShareEnum is a command which can grow really really large if 
> the number of shares and comments are large)

Could it be done in the SMB holding the last fragment instead?

That would mean that

	1) it'd work in Tethereal

and

	2) the dissection of a frame would change less between the first
	   pass and subsequent passes in Ethereal, so it'd be more
	   likely to get the Info column right.

(The fact that the IPv4/IPv6/CLNP fragment reassembly, and the TCP
segment reassembly, attach the reassembled data to the last frame makes
both of those be true for them.)