Hi Tim, Hi list
In what way does it not work?
add_fid() should show the smb.fid field in the tree for anyone
calling it, including when called for TransactNmPipe.
I assume you can actually see the smb.fid thingy in the tree but that
display filters fails to see it?
If that is the case, then I have seen it before (for example for nfs
filehandles, which are also displayed by NLM and Mount dissectors):
smb_fid is declared in the SMB protocol dissector and tied to proto_smb.
If you would call add_fid() form somewhere else, outside of the dissector
for proto_smb, as in say proto_pipe or whatever the smb-pipe
dissector is called, then the displayfilter thingy will not find
smb.fid.
I assume this is some optimization, if dissecting in the tree under the
protocol branch: proto_pipe, then ONLY check hf_index entries
registred for proto_pipe and ignore anything else.
I failed to find how to change this behaviour when I looked at it some time
ago.
Try this:
Perhaps it would work to add hf_index to the add_fid() parameters
and passing hf_smb_fid as a parameter to it everytime it is called from
packet-smb.c.
Then create an identical hf entry inside packet-smb-pipe.c but call it
hf_pipe_fid (let the filter string remain smb.fid) and pass
hf_pipe_fid as a parameter when called from packet-smb-pipe.c
It might work?
From: Tim Potter To: Pia Sahlberg CC: ethereal-dev@xxxxxxxxxxxx
Subject: Re: [Ethereal-dev] SMBpatch for read/write and x
Date: Wed, 28 Nov 2001 23:30:58 +1100
On Wed, Nov 28, 2001 at 11:20:11AM +0000, Pia Sahlberg wrote:
> Attached is a tiny patch which tracks FID values between requests
> and responses for ReadAndX and WriteAndX.
>
> This is needed later by the MSRPC reassembly.
I've just compiled up the latest CVS with new shinier fid tracking
and it doesn't seem to work for the TransactNmPipe packets. This
is despite the add_fid() function being called at the appropriate
place. )-:
Tim.
_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp
