Ethereal-dev: Re: [Ethereal-dev] Re: SMB transaction reassembly patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Wed, 28 Nov 2001 01:10:38 -0800
On Tue, Nov 27, 2001 at 11:33:57PM +0000, Pia Sahlberg wrote:
> I think of the one of the form  if( r_tvb && p_tvb && d_tvb)
> since it just struck me that there might be cases where
> p_tvb is NULL (i.e. no parameters, only data)

Yes - DCERPC-over-SMB-transactions, for example.

> Perhaps it should be changed to be just if (r_tvb)
> (or if(r_tvb && d_tvb)   but could tehre be cases where only parameters
> are specified and no data in the Transaction call?)

Yes - the reply from a SamOEMChangePassword LANMAN remote API request,
for example.

> If none else looks into it I will tonight.

I'm working on it.  Once I get it working, I'll check in your patch,
with changes to stuff I found during regression testing (including the
above).