Ethereal-dev: Re: [Ethereal-dev] SMB Transaction[2] reassebbly

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 26 Nov 2001 01:59:58 -0800
On Sun, Nov 25, 2001 at 11:54:48PM +1100, Ronnie Sahlberg wrote:
> Attached patch fixes a small typo in packet-smb-pipe.c
> (s_tvb where it should be sp_tvb)

Checked in.

> The patch also adds reassembly of fragmented SMB Transaction and
> Transaction2 responses.

Checked in, with some changes found when doing regression testing
(without reassembly enabled).

> It only reassembles the data field of a transaction SMB.
> It only displays the reassembled data field for the Transaction command
> holding the first fragment.

Perhaps if it were done for the command holding the *last* fragment...

> The problem right now with the patch is that when we first see the packet
> holding the first fragment, we do not
> have a fully reassembled packet so we need to rescan the command list (by
> applying an empty "" display filter)
> before we see the proper COL_INFO stuff and before displayfilters works on
> parts of the reassembled PDU not residing inside the
> first fragment.

...that wouldn't be an issue.

The reassembled data is only shown for the last fragment for
IPv4/IPv6/CLNP reassembly, and TCP segment reassembly, so that problem
doesn't show up there.