Ethereal-dev: Re: [Ethereal-dev] [PATCH] fid tracking

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 17 Nov 2001 15:46:37 -0800
On Sun, Nov 18, 2001 at 09:17:34AM +1100, Ronnie Sahlberg wrote:
> Please if possible try to keep smb_info as small as possible. It affects the
> runtime requirement of ethereal and thethereal.

Only a tiny amount - the only "smb_info" structure is the one in
"dissect_smb()"s stack frame, as of my previous checkins.  Memory
consumption is not a reason not to add more stuff to it.

The structure that should be kept small is the "smb_saved_info_t"
structure; that's the one that's now allocated for every request.

I'm working on shrinking that one as per

> Perhaps the smb_info handling should be changed as Guy suggested to just
> contain frame_req/frame_res and
> a void * to point to protocol specific data.