Hi list,
This patch will tvbuffify the last remaining transaction command.
Note that the interface to dissect_pipe_lanman() has changed.
It now takes two tvbuffs as parameters, one tvbuff for the parameter area
and
one tvbuff for the data area.
This is why I ifdefed out the call to dissect_pipe_msrpc()
Perhaps Tim Potter on this list (which is more familiar with the msrpc code
than myself)
could have a quick look at this patch.
Would it be trivial to change msrpc to reflect the new interface?
If it would be hard and a lot of work then I can generate a new diff which
brings back the old
interface to dissect_pipe_lanman()
The reason for this change in interface is that this would allow several
variables in smb_info to be removed.
I think of data_offset and friends.
smb_info is right now quite large but I think it would be fairly easy to
remove some of the variables
one by one to slim it down.
some cleanup to do in packet-smb.c and smb.h which will take some time
then one can add something really cool as reassembley of transaction calls.
Attachment:
smb_patch.diff.gz
Description: GNU Zip compressed data
