Wireshark · Ethereal-dev: Re: [Ethereal-dev] packet-smb big patch

[Guy Harris <gharris@xxxxxxxxx>]

On Mon, Nov 12, 2001 at 08:10:32PM +1100, Ronnie Sahlberg wrote:
> I will generate the last part of my smb patches to fix the transaction call
> based on current cvs.

BTW, note that the stuff done by "do_transaction_hashing()", where it
includes frame numbers as part of the hash key, really *is* necessary -
and should probably be done for all SMB requests and replies; I have at
least one capture with multiple Transaction2 SMB exchanges in a row, all
with the *same* MID, PID, UID, adn TID, and all between the same
machines on the same connection....

(There should perhaps be a hash table matching requests and replies,
using the same hashing that "do_transaction_hashing()" does now, with
the structure associated with each hash table entry not being a
full-blown "smb_info" structure, but something with just enough to
supply the information that can't be extracted from the SMB itself, as
well as a "void *" that can be used to point to other data, e.g. the
transaction stuff.

That'd mean you'd only have the transaction stuff in the hash table
entries for transactions.)