Ethereal-dev: [Ethereal-dev] packet-smb.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Ronnie Sahlberg" <rsahlber@xxxxxxxxxxxxxx>
Date: Fri, 2 Nov 2001 21:52:20 +1100
Hi list, Hi Guy

Attached is a patch for packet-smb.It should apply cleanly to current CVS.
Thew patch mainly changes dissect_smb() (rewrite) and adds the nessecary
infrastructure for
changing all SMB commands to tvbuffified rewritten versions.

This patch should (almost) only change dissect_smb() but still call and use
all old style dissectors for the
commands.
COL_INFO presentation is changed though and the names of all SMB commands
are changed to closer
reflect the leach document.
Othervise, all original command dissectors in SMB will be used as in the old
version.

I have currently a version (complete rewrite) of packet-smb.c which is
tvbuffified and implements all of leach.

If this patch providing the infrastructure needed is appied I will provide
incremental patches which will replace
the old style command dissectors with tvbuffified and rewritten ones, 5-10
commands at a time.
I can provide incremental patches for all remaining smb copmmands in a
matter of days but would prefere to
do this incrementally since maintaining a huge diff for packet-smb.c is
currently a lot of work.

After which we will have a completely tvbuffified smb dissector which has
display filters for every single field and
can dissect Trans, Trans2 and NTTrans commands.


best regards
    ronnie s

Attachment: smb_patch1.diff.gz
Description: GNU Zip compressed data