On Thu, Nov 01, 2001 at 09:43:31AM +0100, Tomas Kukosa wrote:
> Some mistakes seem to be in plugin_api_defs.h. Second parameters of
> following functions have different type than new version of tvbuff.*.
>
> gint (*p_tvb_find_guint8)(tvbuff_t*, gint, guint, guint8);
> should be
> gint (*p_tvb_find_guint8)(tvbuff_t*, gint, gint, guint8);
>
> gint (*p_tvb_pbrk_guint8)(tvbuff_t *, gint, guint, guint8 *);
> should be
> gint (*p_tvb_pbrk_guint8)(tvbuff_t *, gint, gint, guint8 *);
I've checked in changes to fix that.
> Would not be better write plugin_api_defs.h in following form?
> addr_check_col p_check_col;
> addr_col_clear p_col_clear;
> addr_col_add_fstr p_col_add_fstr;
> ...
> It would require less effort for changes.
I'll look into that. Note, however, that it wouldn't have fixed the
problem in question - the typedefs for "addr_tvb_find_guint8" and
"addr_tvb_pbrk_guint8" were also wrong (my checking fixed those as
well).
