Wireshark · Ethereal-dev: Re: [Ethereal-dev] patch for packet-ip.c

[Guy Harris <guy@xxxxxxxxxx>]

> tiny tiny patch to enable dissection of icmp payload

I have a change to do that (it also makes the columns non-writable, so
that the packet shows up in the summary list as an ICMP packet, rather
than as the "invoking packet", to use the ICMPv6 term), as well, but
I've been waiting for the last of the dissectors to be tvbuffified
before checking that in; only a small amount of the invoking packet is
included, so I'd be nervous about some untvbuffified dissector running
past the end.

The only untvbuffified dissectors are the SOCKS and SMB dissectors. 
The SOCKS dissector only dissects TCP, and SMB would run only over TCP
or UDP.

Unless some ICMP implementation puts more than "Internet Header
+ 64 bits of Original Data Datagram" into an ICMP message, the TCP or
UDP payload won't be in the ICMP reply, so the SOCKS and SMB dissectors
shouldn't be called.

As such, I'll probably just check my change in when I get home, and
worry about problems if they show up.