Ethereal-dev: Re: [Ethereal-dev] Sun C cannot build packet-rx.h

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 19 Aug 2001 19:14:04 -0700
On Sun, Aug 19, 2001 at 07:33:09PM -0500, ethereal-dev@xxxxxxxxxxxxxxxxxx wrote:
> #define RX_MAXCALLS     4
> struct rxkad_response {

	...

>         u_char  the_ticket[0];
> };

That structure isn't actually used by the RX dissector, so I removed it
from "packet-rx.h" - along with the other structures, which also aren't
used.

Note to developers: zero-length arrays are Not C, and not accepted by
all C compilers, so don't use them.  Check out section 1.1.1
"Portability" in the current version of "doc/README.developer", which
gives a list of features to avoid.