Ethereal-dev: Re: [Ethereal-dev] patch - fix giop malformed frame

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Frank Singleton <frank.singleton@xxxxxxxxxxxx>
Date: Fri, 27 Jul 2001 11:19:49 -0500
Frank Singleton wrote:
> 

>   ------------------------------------------------------------------------
> --- packet-giop.c       2001/07/27 12:39:43     1.1
> +++ packet-giop.c       2001/07/27 13:17:00
> @@ -9,7 +9,7 @@
>   * Frank Singleton <frank.singleton@xxxxxxxxxxxx>
>   * Trevor Shepherd <eustrsd@xxxxxxxxxxxxxxx>
>   *
> - * $Id: packet-giop.c,v 1.1 2001/07/27 12:39:43 frank Exp $ <== not original
> + * $Id: packet-giop.c,v 1.4 2001/07/27 13:17:00 frank Exp $
>   *
>


Oops, try this instead.  You may get a rej on the above
line.

/Frank..

-- 
EUS/SV/Z Frank Singleton      ASO Americas BSS
Office : +1 972 583 3251      ECN 800 33251  
Mobile : +1 214 228 0874      Amateur Radio: VK3FCS/KM5WS   
Email : frank.singleton@xxxxxxxxxxxx

Hardware: HP Omnibook 4150 running Redhat Linux 7.1 (2.4.3-12 kernel).
--- ../ethereal-2001-07-27/packet-giop.c	Thu Jul 26 11:59:28 2001
+++ ../ethereal-2001-07-27.updated/packet-giop.c	Fri Jul 27 08:17:00 2001
@@ -9,7 +9,7 @@
  * Frank Singleton <frank.singleton@xxxxxxxxxxxx>
  * Trevor Shepherd <eustrsd@xxxxxxxxxxxxxxx>
  *
- * $Id: packet-giop.c,v 1.44 2001/07/26 16:59:28 guy Exp $
+ * $Id: packet-giop.c,v 1.4 2001/07/27 13:17:00 frank Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Gerald Combs <gerald@xxxxxxxxxxxx>
@@ -4385,16 +4385,16 @@
 
   default:
     
-    /* fetch all octets in this sequence */
+    /* fetch all octets in this sequence , but skip endianess */
       
-    get_CDR_octet_seq(tvb, &profile_data, offset, seqlen_pd);
+    get_CDR_octet_seq(tvb, &profile_data, offset, seqlen_pd -1);
       
     /* Make a printable string */
       
-    p_profile_data = make_printable_string( profile_data, seqlen_pd );
+    p_profile_data = make_printable_string( profile_data, seqlen_pd -1);
       
     if(tree) {
-      proto_tree_add_text (tree, tvb, *offset -seqlen_pd, seqlen_pd,
+      proto_tree_add_text (tree, tvb, *offset -seqlen_pd + 1, seqlen_pd - 1,
 			   "Profile Data: %s", p_profile_data);
     }