Wireshark · Ethereal-dev: Re: [Ethereal-dev] warning patches

[Guy Harris <guy@xxxxxxxxxx>]

> Just a few warning patches that accumulated over the last few weeks
> (I may have sent some of them already but in that case, the have been
> ignored/lost).

Checked in (although with "-Wno-unused", to reduce the noise level a
bit; I'm tempted to add a configuration option to turn off both "-W" and
"-Wno-unused", so I can do a build that'll check for unused *variables*
without spamming me with a zillion complaints about unused *parameters*
- there's an __attribute__ option to mark parameters as unused, but
there'd have to be a lot of that shoveled in to squelch the complaints
about unused parameters).

BTW, we're currently checking for "__GNUC__ == 2" to decide whether to
include "__attribute__((format (printf, N, M)))" items; should that be
changed to "__GNUC__ >= 2" for GCC 3.0, or is __GNUC__ defined as 2 in
GCC 3.0?