Ethereal-dev: Re: [Ethereal-dev] cleanup patch for get_column_format_matches

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Tue, 10 Jul 2001 21:45:14 -0700
On Mon, Jul 09, 2001 at 08:25:50AM -0400, Todd Sabin wrote:
> I was trying to figure out what get_column_format_matches was supposed
> to do, and I just couldn't understand the for loop.  Probably because
> it's completely superfluous.  Nothing in the switch depends on i, and
> the if (i==format) can be gotten rid of.  If format is guaranteed to
> be legal, you can even get rid of the refactored if, though I didn't
> do that.

Checked in.