Ethereal-dev: Re: [Ethereal-dev] New dissector: MSDP

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Tue, 10 Jul 2001 18:02:53 -0700 (PDT)
> Here is a dissector for MSDP (Multicast Source Discovery Protocol).

Checked in.

> Some packets, such as packet number 129, contain encapsulated IP
> packets.

If this is like PIM, where Register messages contain encapsulated IP
packets, you might want to do as PIM does, and call

	col_set_writable(pinfo->fd, FALSE);

before calling the IP dissector, so that the information columns reflect
the MSDP packet rather than the encapsulated packet.

>         proto_msdp = proto_register_protocol("Multicast Source Discovery Protocol",
>             "MSDP", "MSDP");

That should be

        proto_msdp = proto_register_protocol("Multicast Source Discovery Protocol",
            "MSDP", "msdp");

The third name in a "proto_register_protocol()" is the name used in
capture filters, and it's a pain if you have to type that name in all
caps (it's also inconsistent with the names of the fields in the
protocol, which begin with "msdp").

I checked it in with the third name being all lower case.