Ethereal-dev: Re: [Ethereal-dev] allowing (sub-)dissector to know preferences of anotherdisse

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Ed Warnicke <hagbard@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 9 Jul 2001 18:57:29 -0400 (EDT)
That being said... just because it's being done other places doesn't mean 
it's a good idea.  Wouldn't it make more sense to build an api for
querying the preference values rather than querying them via 
compile time linking?  

I'd really like to see as much of the compile time dependencies between 
dissectors go away as possible...  

Ed

On Mon, 9 Jul 2001, Guy Harris wrote:

> > Actually, I just figured someone would come hunt me down for putting a
> > non-static variable in a dissector and referencing it from another
> > dissector.  ;)
> 
> There are other cases of that:
> 
> 	{hostname}$ egrep extern packet-*.h | egrep -v '\(' | more
> 	packet-chdlc.h:extern const value_string chdlc_vals[];
> 	packet-frame.h:extern int proto_malformed;
> 	packet-ip.h:extern dissector_table_t ip_dissector_table;
> 	packet-ncp-int.h:extern int proto_ncp;
> 	packet-rpc.h:extern const value_string rpc_auth_flavor[];
> 	packet-tcp.h:extern guint16   tcp_urgent_pointer;
> 	packet-wap.h:extern const value_string vals_character_sets[];
> 	packet-wccp.h:extern const value_string service_id_vals[];
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>