Ethereal-dev: Re: [Ethereal-dev] incorrect L2TP tie breaker decode

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Fri, 8 Jun 2001 19:18:22 -0700 (PDT)
> This AVP should probably be treated like the Challenge
> and Challenge Response AVPs, which are arbitarily long byte sequences.
> These sequences are not displayed, but can be seen in the raw byte
> window
> (I didn't know of an easy way to dump a sequence of 8-bytes).

Declare a bunch of named fields for the various AVP values (rather than
incorrectly using "hf_l2tp_code", as the dissector currently does), and
make the 64-bit value an FT_BYTES field - it'll get displayed as raw hex
digits.

In fact, by doing that, you can also get rid of a pile of
"proto_tree_add_uint_format()" calls and replace them with
"proto_tree_add_item()" calls, which do a lot of the work for you.