Ethereal-dev: Re: [Ethereal-dev] As Promised -- New Diameter Dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Mon, 19 Feb 2001 15:20:20 -0800
On Mon, Feb 19, 2001 at 04:49:03PM -0600, David Frascone wrote:
> Tons of cleanup was done -- Almost a complete rewrite

Checked in.

> 	o	No longer impacts UDP packets, so packet-radius.c no
> 		longer calls this dissector.

As "dissect_diameter()" is now static to "packet-diameter.c", this means
that it doesn't need to be declared in "packet-diameter.h" - and the
only thing "packet-diameter.h" did was to declare "dissect_diameter()",
so I got rid of that header file.

It also means that it's called only through dissector tables or
dissector handles, so it doesn't need to call "CHECK_DISPLAY_AS_DATA()"
or set "pinfo->current_proto" - the code to call through dissector
tables and dissector handles does that for it - so I removed the code to
do that as well.