On Fri, Jan 26, 2001 at 04:17:25PM -0200, Alexandre P. Ferreira wrote:
> I've apologize for sending and e-mail without the attachment.
>
> Attached is a patch that improves and corrects the dissector for WSP and
> includes WTLS (non crypto parts).
Some comments:
1) the WSP dissector has changed somewhat between 0.8.15 and the
current version in CVS, so the patch wouldn't apply to the
current CVS code without a lot of extra work - you should
probably either use anonymous CVS:
http://www.ethereal.com/development.html#anoncvs
or get one of the nightly source snapshots from
http://www.ethereal.com/distribution/nightly-builds/
2) almost none of "dissect_wsp()" is shared between the WSP and
WTLS dissector, so it should be split into "dissect_wsp()"
and "dissect_wtls()"; you'd then do
dissector_add("udp.port", UDP_PORT_WTLS_WSP, dissect_wtls, proto_wtls);
for the WTLS port.
3) "dissect_wtls()" would then still have rather a lot of levels
of indentation; you'd probably want to use more subroutines,
for the benefit of those whose editor windows aren't the full
width of the screen or who don't use 6-pixel fonts.
