Wireshark · Ethereal-dev: Re: [Ethereal-dev] ethereal fails to work with loopback device on OpenBSD (patch inside)

[Guy Harris <gharris@xxxxxxxxxxxx>]

On Sat, Jan 27, 2001 at 11:04:31PM +0200, Denis A. Doroshenko wrote:
> after some diggin around wiretap directotry and especially libpcap.c
> file, i made such changes, that makes ethereal work with the loopbacks
> as expected.

Those changes should not be necessary, given that "wiretap/libpcap.c"
includes <pcap.h> if HAVE_PCAP_H is defined, and <pcap.h> includes, on
OpenBSD (and other BSDs, and other non-BSDs) the header fils you add.

The problem is that the "AC_WIRETAP_PCAP_CHECK" macro in
"wiretap/acinclude.m4" was using AC_CHECK_HEADER, not AC_CHECK_HEADERS,
to check for "pcap.h"; this resulted in a definition of HAVE_PCAP_H not
being added to "config.h" by the configure script, which resulted in
"wiretap/libpcap.c" not including <pcap.h>.

Try backing out your change to "libpcap.c", applying the attached patch
to "wiretap/acinclude.m4", running "autoreconf" in the "wiretap"
directory, removing the "config.cache" file from that directory, and
re-running the top-level configure script.

> will the changes see the light in 0.8.16? :-)

The changes to wiretap/libpcap.c?  No, as they're just a workaround for
the real bug, and treat OpenBSD specially.

The change to wiretap/acinclude.m4?  Yes, as they fix the underlying
problem.

? errs
? NBIPX-PLEEEEEZE
? packet-icq.c.NEW
? packet-wsp.c.NEW
? packet-sdp.c.CONVERSATION
? epan/charsets.h
? wiretap/gzio.c
? wiretap/zlib-1.1.3
Index: wiretap/acinclude.m4
===================================================================
RCS file: /usr/local/cvsroot/ethereal/wiretap/acinclude.m4,v
retrieving revision 1.6
diff -c -r1.6 acinclude.m4
*** acinclude.m4	2000/08/25 06:25:20	1.6
--- acinclude.m4	2001/01/27 23:41:11
***************
*** 226,232 ****
  	fi
  
  	# Pcap header check
! 	AC_CHECK_HEADER(pcap.h)
  ])
  
  #
--- 226,232 ----
  	fi
  
  	# Pcap header check
! 	AC_CHECK_HEADERS(pcap.h)
  ])
  
  #