Ethereal-dev: Re: [Ethereal-dev] IP Fix and SSDP support

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Tue, 2 Jan 2001 19:26:29 -0800
On Tue, Jan 02, 2001 at 06:32:15PM -0800, dhampton@xxxxxxx wrote:
> Attached are changes that add SSDP and other tweaks to the HTTP code,
> and a change that fixes pure IP packets to display properly (they
> display as raw Ethernet packets for me.)

What is a "pure IP packet"?

> Index: packet-ip.c
> ===================================================================
> RCS file: /cvsroot/ethereal/packet-ip.c,v
> retrieving revision 1.115
> diff -u -r1.115 packet-ip.c
> --- packet-ip.c	2000/12/29 04:16:57	1.115
> +++ packet-ip.c	2001/01/03 01:17:44
> @@ -840,6 +840,11 @@
>    /* XXX - check to make sure this is at least IPH_MIN_LEN. */
>    hlen = lo_nibble(iph.ip_v_hl) * 4;	/* IP header length, in bytes */
>    
> +  if (check_col(pinfo->fd, COL_PROTOCOL))
> +    col_set_str(pinfo->fd, COL_PROTOCOL, "IP");

The code in version 1.115 of "packet-ip.c" already sets the Protocol
column before that point in the code; I'm extremely skeptical that
adding those two lines would affect anything.

> +  if (check_col(pinfo->fd, COL_INFO))
> +    col_set_str(pinfo->fd, COL_INFO, "IP Packet");
> +

Similarly, the code in version 1.115 of "packet-ip.c" already clears the
Info column, and, if the packet isn't handled by any higher-level
protocol such as TCP or UDP, the Info column gets set later to give the
protocol name and number.

Do you have a capture that exhibits the behavior you say you saw?