Good. I had just about run out of steam at the end of FT_STRING, but
intended to come back to FT_ETHER. You doing it will provide a bit
more sanity check to the code (using code is so much more illuminative
than reading it).
As to moving th FT_* stuff into separate files, more modularity almost
always sounds like a good idea to me.
Ed
On Tue, 2 Jan 2001 Gilbert_Ramirez@xxxxxxxxxx wrote:
> Thanks, it looks pretty good. I'm going to adapt the FT_ETHER stuff to work
> with dranges, and then I'll
> check it in. BTW, I'm working on moving the type-related stuff (FT_* types)
> into separate files; this allows
> a cleaner object-oriented approach to the whole thing. This will enable use
> to do better work on enhancing
> the dfilter code.
>
> --gilbert
>
> Ed Warnicke <hagbard@xxxxxxxxxxxxxxxxxxx>@ethereal.com on 12/30/2000
> 08:34:03 PM
>
> Sent by: ethereal-dev-admin@xxxxxxxxxxxx
>
>
> To: ethereal-dev@xxxxxxxxxxxx
> cc:
> Subject: [Ethereal-dev] ranges for dfilter
>
>
>
> Here is a patch to ethereal and a tarball containing two new
> source files that implements generalized ranges for filters and
> extending these ranges from just FT_BYTES to FT_STRINGS as well.
>
> The mechanism for extending ranges to other sequence types are
> also fairly well generalizes, so applying ranges to other
> types should not be very hard.
>
> Since this is the first large scale change I've written to something
> in the core of ethereal I would appreciate it if someone would look over
> it for a sanity check and then check it in.
>
> Ed
>
> (See attached file: drange-20001230.tar.gz)
> (See attached file: 55.patch)
>
